refactor(prt): simplify face numbering scheme #2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #2546, convert PRT FMI boundary flows from flat array with fixed offset to 2D array with 2nd dimension face numbers. The 2nd dimension uses
icellfacenumbering, the internal "grid-aligned" scheme which shiftsiflowfacenegative top and bottom to the end of an interval from 0 to (grid max lateral cell faces + 2).This simplifies the structured and vertex methods, no more need to compute an offset. Also define constants for top/bottom face numbers in the iflowface numbering scheme.